rambleraptor commented on code in PR #3492:
URL: https://github.com/apache/iceberg-python/pull/3492#discussion_r3590091816
##########
pyiceberg/io/fsspec.py:
##########
@@ -201,7 +201,7 @@ def _s3(properties: Properties) -> AbstractFileSystem:
if request_timeout := properties.get(S3_REQUEST_TIMEOUT):
config_kwargs["read_timeout"] = float(request_timeout)
- if _force_virtual_addressing :=
properties.get(S3_FORCE_VIRTUAL_ADDRESSING):
Review Comment:
There's probably more of these issues throughout the codebase. Ideally, we
could make a full Properties class that could handle most of this for us
(instead of properties just being a dict)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
