dttung2905 commented on code in PR #72:
URL:
https://github.com/apache/terraform-provider-iceberg/pull/72#discussion_r3590503702
##########
dev/release/verify_rc.sh:
##########
Review Comment:
ensure_go() sets GOPATH but not GOMODCACHE. If a voter has GOMODCACHE
exported globally, builds may use (and go clean -modcache may wipe) their
personal cache instead of the sandbox.
I would say
```
ensure_go() {
if [ "${VERIFY_FORCE_USE_GO_BINARY}" -le 0 ]; then
if go version; then
GOPATH="${VERIFY_TMPDIR}/gopath"
export GOPATH
GOMODCACHE="${GOPATH}/pkg/mod"
export GOMODCACHE
mkdir -p "${GOMODCACHE}"
return
fi
fi
```
##########
dev/release/verify_rc.sh:
##########
Review Comment:
Similar to the above
```
...
export GOPATH
// New
GOMODCACHE="${GOPATH}/pkg/mod"
export GOMODCACHE
mkdir -p "${GOMODCACHE}"
// End of New
PATH="${GOROOT}/bin:${GOPATH}/bin:${PATH}"
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
