sungwy commented on PR #73: URL: https://github.com/apache/terraform-provider-iceberg/pull/73#issuecomment-4985650403
Thanks for the review @RussellSpitzer > I looked manually and it seemed fine. Bot told me that we're missing arrow-go + thrift. I'm seeing a partial license for arrow-go. Do we need thrift since it's a transitive dependency? That's a good point @rambleraptor - I intentionally left it out initially because I thought we didn't need to include other Apache Software Foundation projects into the NOTICE file. But this document seems to leave this a bit ambiguous: https://infra.apache.org/licensing-howto.html#bundle-asf-product ``` Bundling other ASF products It is not necessary to duplicate the line "This product includes software developed at the Apache Software Foundation...", though the ASF copyright line and any other portions of NOTICE must be considered for propagation. ``` There's precedent in apache/spark and apache/iceberg/kafka-connect-runtime for including other ASF projects into the NOTICE file. So I think it would make sense to include these (and iceberg-go) too. Spark: https://github.com/apache/spark/blob/e9121bbf5a94b724b195a6f11c35a1a2d562e3d5/NOTICE-binary#L60-L64 kafka-connect-runtime: https://github.com/apache/iceberg/blob/98e9e43de56a9378a8e6434cc160bc3faeeab9be/kafka-connect/kafka-connect-runtime/main/NOTICE#L105-L107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
