aarushigupta132 commented on code in PR #2701:
URL: https://github.com/apache/iceberg-rust/pull/2701#discussion_r3591541503
##########
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##########
@@ -46,6 +47,43 @@ use crate::transform::create_transform_function;
use crate::writer::{CurrentFileStatus, DataFile};
use crate::{Error, ErrorKind, Result};
+enum OutputTarget {
+ Plain(OutputFile),
+ Encrypted(EncryptedOutputFile),
+}
+
+impl OutputTarget {
+ async fn writer(&self) -> Result<Box<dyn FileWrite>> {
+ match self {
+ Self::Plain(o) => o.writer().await,
+ Self::Encrypted(e) => e.writer().await,
Review Comment:
thank you for the comments. i realise my first attempt was a very naive stab
🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
