wgtmac commented on PR #708: URL: https://github.com/apache/iceberg-cpp/pull/708#issuecomment-4987673068
I've made several changes to this PR: - Kept puffin and dv code in `iceberg-data` library to make the core library IO-less still. - Refactored DV logic based on a recent commit which added DV writer and reader support. - Removed `misc-include-cleaner` from clang-tidy since I found it is useless but adds a lot of noise by blocking every ci until we add a lot of lengthy include statements. - Removed ci workflow for sigv4 with meson. Recently vcpkg update introduced a breaking change of aws sdk. I think this workflow is fragile but there is no active Meson expert. Considering that Meson is still partially supported, I don't want to waste time and burn tokens to fix it. So I directly removed this workflow and may eventually remove all Meson code if unmaintained for a long time (perhaps a year?). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
