c-thiel commented on PR #2832:
URL: https://github.com/apache/iceberg-rust/pull/2832#issuecomment-4990068078
> Thank you, this looks great.
>
> QQ: Should we add tests with different time zones?
Good call, added tests for it. Spec says the offset must be +00:00 and Java
enforces the same (isUTCTimestamptz), so I added
json_timestamptz_ns_rejects_non_utc_offset + the micros counterpart asserting a
non-UTC offset is rejected (matching Java's testInvalidTimestamptz{,Nano}).
+00:00 round-trip is already covered.
One note: we accept only the literal +00:00, not Z like Java does — spec
mandates +00:00 and both writers emit it, so round-trips are fine. I would keep
it strict for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
