thswlsqls opened a new pull request, #17252: URL: https://github.com/apache/iceberg/pull/17252
Documents the behavior reported in #15808 ## Summary - `NullabilityHolder.reset()` clears only `numNulls`; the `isNull` marker array read by `isNullAt(int)` is left as-is. - This is intentional, not a bug: for every batch, `VectorizedParquetDefinitionLevelReader` sets the marker of each index via `setNull`/`setNotNull` (or the bulk `setNulls`/`setNotNulls`) before any marker is read, so values from a previous batch are overwritten rather than observed. - Add Javadoc on `reset()` stating this contract, so the behavior is not mistaken for a stale-state bug. - On closed PR #16264, the reviewer noted writers set all values explicitly and suggested documenting this instead of changing `reset()`. ## Testing done - Javadoc-only change, no behavior change — no test added. - `./gradlew :iceberg-arrow:spotlessCheck` — passed. - `./gradlew :iceberg-arrow:checkstyleMain` — passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
