fallintoplace opened a new pull request, #1482: URL: https://github.com/apache/iceberg-go/pull/1482
## Summary - preserve an accepted empty snapshot log when rebuilding metadata after snapshot removal - validate the current snapshot against the last log entry only when a retained entry exists - add a regression covering removal from metadata with a current snapshot and an empty log ## Why Table metadata may contain a current snapshot with an empty snapshot log. Removing another snapshot rebuilt the empty log and then indexed its final entry, causing a slice-bounds panic. An empty log has no historical transition to validate or synthesize, so it should remain empty. Nonempty logs still require their final entry to reference the current snapshot. ## Testing - `go test ./table` - `go test -race ./table -run "TestRemoveSnapshotsPreservesEmptySnapshotLog|TestSnapshotLogSkipsIntermediate|TestRemoveSnapshotsPrunesStatistics" -count=1` - `go vet ./table` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
