fallintoplace opened a new pull request, #1485: URL: https://github.com/apache/iceberg-go/pull/1485
## Summary - snapshot matching MemFS entries while holding the read lock - release the lock before invoking `WalkDir` callbacks - add a regression test that removes each visited file from the callback ## Problem `MemFS.WalkDir` held its read lock throughout traversal. If a callback called a mutating method such as `Remove` or `WriteFile`, that method waited for the write lock while the same traversal still held the read lock, causing a deadlock. ## Fix Capture each matching path and its immutable directory-entry metadata under the read lock, then invoke callbacks after unlocking. This preserves the existing filtering, metadata, iteration behavior, and callback error handling without copying file contents. ## Testing - `go test ./io` - `go test -race ./io` - `go vet ./io` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
