badalprasadsingh commented on PR #1359: URL: https://github.com/apache/iceberg-go/pull/1359#issuecomment-4996259395
Done. Removed the `TODO` that I had added for it. Couldn't reuse `AddColumn's Literal.Type().Equals` check directly since union defaults are raw `any`. Added a `validateDefaultValue` helper that runs each raw default through the same `defaultToScalar` conversion used on the read/write paths, so anything that would panic downstream is now rejected during Apply instead. Added it into `unionAddColumn` and `setWriteDefault`. Added respective tests for it as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
