rdblue commented on a change in pull request #1870: URL: https://github.com/apache/iceberg/pull/1870#discussion_r549528014
########## File path: core/src/main/java/org/apache/iceberg/jdbc/JdbcClientPool.java ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.jdbc; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.SQLException; +import java.sql.SQLNonTransientConnectionException; +import java.sql.SQLTimeoutException; +import java.sql.SQLTransientConnectionException; +import java.sql.SQLWarning; +import java.util.Properties; +import org.apache.iceberg.ClientPool; +import org.apache.iceberg.exceptions.UncheckedSQLException; + +public class JdbcClientPool extends ClientPool<Connection, SQLException> { + + private final String dbUrl; + private final Properties dbProperties; + + JdbcClientPool(String dbUrl, Properties props) { + this((Integer) props.getOrDefault("iceberg.jdbc.client-pool-size", 5), dbUrl, props); + } + + public JdbcClientPool(int poolSize, String dbUrl, Properties props) { + super(poolSize, SQLException.class); + dbProperties = props; + this.dbUrl = dbUrl; + } + + @Override + protected Connection newClient() { + try { + return DriverManager.getConnection(dbUrl, dbProperties); + } catch (SQLTimeoutException e) { + throw new UncheckedSQLException("Connection timeout!", e); + } catch (SQLTransientConnectionException | SQLNonTransientConnectionException e) { + throw new UncheckedSQLException("Connection failed!", e); + } catch (SQLWarning e) { + throw new UncheckedSQLException("Database connection warning!", e); + } catch (SQLException e) { + throw new UncheckedSQLException("Failed to connect to database!", e); + } + } + + @Override + protected Connection reconnect(Connection client) { + this.close(client); Review comment: No need to prefix with `this` when calling a method or reading a field. We only add it to distinguish between setting instance fields (`this.x = ...`) and local variables (`x = ...`). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
