yadavay-amzn commented on PR #17205: URL: https://github.com/apache/iceberg/pull/17205#issuecomment-4996467178
Thanks for taking a look. You're both right that RewritePositionDeletes already clears these as part of a rewrite. The one thing that nudged me here is that RemoveDanglingDeletes already handles DVs and partition-scoped position deletes, so file-scoped v2 deletes are the only delete type it skips, which felt like a small internal inconsistency. And since it only rewrites metadata, it gets there without rewriting the position delete files themselves. That said, if the intended maintenance story is RewritePositionDeletes for V2 and RemoveDanglingDeletes for V3, I'm fine dropping this and leaving it there. Happy to go whichever way you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
