rdblue commented on code in PR #17260:
URL: https://github.com/apache/iceberg/pull/17260#discussion_r3599459573
##########
core/src/main/java/org/apache/iceberg/variants/ShreddedObject.java:
##########
@@ -39,12 +40,12 @@
* fields. This also does not allow updating or replacing the metadata for the
unshredded object,
* which could require recursively rewriting field IDs.
*/
-public class ShreddedObject implements VariantObject {
+public class ShreddedObject implements VariantObject, Serializable {
private final VariantMetadata metadata;
private final VariantObject unshredded;
private final Map<String, VariantValue> shreddedFields = Maps.newHashMap();
private final Set<String> removedFields = Sets.newHashSet();
- private SerializationState serializationState = null;
+ private transient SerializationState serializationState = null;
Review Comment:
This is lazily created, so there is no problem making it transient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
