plusplusjiajia commented on PR #2815:
URL: https://github.com/apache/iceberg-rust/pull/2815#issuecomment-4998985170
> Hey @plusplusjiajia , thanks for this contribution! I really like the
general direction. To move forward, could you break this down to several
smaller PRs? For example you can break it down to 2-3 PRs:
>
> 1. Introduce AuthManager/Session traits and migrate existing oauth2 to use
the new traits
> 2. Add Sigv4 support
@CTTY Thanks for the review! Agreed — I'll split this into:
1. `AuthManager`/`AuthSession` traits + migrating the existing OAuth2 flow
(pure refactor, no behavior change);
2. SigV4 support on top — reworking #2660 in place once the traits PR
lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
