zeroshade commented on PR #1355: URL: https://github.com/apache/iceberg-go/pull/1355#issuecomment-5004955341
@laskoviymishka when you get a chance, could you take another look here? Your last note said everything you'd flagged was covered, and I re-reviewed the current revision — `fitDecimalBytes` now sign-extends negative decimals and rejects oversized values unless the dropped prefix is redundant sign extension, with the added round-trip/precision coverage. I've approved on my side; if you're happy with it, converting your review would let it merge. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
