xanderbailey commented on code in PR #2677:
URL: https://github.com/apache/iceberg-rust/pull/2677#discussion_r3604856695
##########
crates/iceberg/src/transaction/append.rs:
##########
@@ -402,6 +404,115 @@ mod tests {
);
}
+ /// See `testdata/manifests_lists/README.md`.
+ const FIXTURE_MASTER_KEY_ID: &str = "master-1";
+ const FIXTURE_MASTER_KEY_BYTES: [u8; 16] = [
+ 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0a,
0x0b, 0x0c, 0x0d, 0x0e,
+ 0x0f,
+ ];
+
+ async fn make_v3_encrypted_table() -> Table {
+ let json = fs::read_to_string(format!(
+ "{}/testdata/table_metadata/TableMetadataV3ValidEncryption.json",
+ env!("CARGO_MANIFEST_DIR")
+ ))
+ .unwrap();
+ let metadata = serde_json::from_str::<TableMetadata>(&json).unwrap();
+
+ let kms = MemoryKeyManagementClient::new();
+ kms.add_master_key_bytes(
+ FIXTURE_MASTER_KEY_ID,
+ SensitiveBytes::new(FIXTURE_MASTER_KEY_BYTES),
+ )
+ .unwrap();
+
+ let file_io = FileIO::new_with_memory();
+
+ let manifest_list_bytes = fs::read(format!(
+ "{}/testdata/manifests_lists/manifest-list-v3-encrypted.avro",
+ env!("CARGO_MANIFEST_DIR")
+ ))
+ .unwrap();
+ let parent_manifest_list =
metadata.current_snapshot().unwrap().manifest_list();
+ file_io
+ .new_output(parent_manifest_list)
+ .unwrap()
+ .write(manifest_list_bytes.into())
+ .await
+ .unwrap();
+
+ Table::builder()
+ .metadata(metadata)
+ .metadata_location("memory:///table/metadata/v1.json")
+ .identifier(TableIdent::from_strs(["ns1", "enc"]).unwrap())
+ .file_io(file_io)
+ .kms_client(Arc::new(kms))
+ .runtime(test_runtime())
+ .build()
+ .unwrap()
+ }
+
+ #[tokio::test]
+ async fn
test_commit_with_encryption_adds_keys_and_records_snapshot_key_id() {
Review Comment:
Nice test!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
