swapna267 commented on code in PR #16450:
URL: https://github.com/apache/iceberg/pull/16450#discussion_r3606303640
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicTableRecordGenerator.java:
##########
@@ -28,12 +34,61 @@
public abstract class DynamicTableRecordGenerator implements
DynamicRecordGenerator<RowData> {
Review Comment:
This wasn't an issue when initial PR was opened, as
DynamicTableRecordGenerator wasn't released yet.
As it's released now, yes adding a overloaded constructor. And single arg
rowType also makes sense as simple implementations can still use it. So keeping
Single arg constructor also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
