CTTY commented on code in PR #2746:
URL: https://github.com/apache/iceberg-rust/pull/2746#discussion_r3606763612
##########
crates/iceberg/src/arrow/reader/pipeline.rs:
##########
@@ -207,6 +209,36 @@ impl FileScanTaskReader {
arrow_metadata
};
+ let project_pos =
task.project_field_ids().contains(&RESERVED_FIELD_ID_POS);
+
+ let arrow_metadata = if project_pos {
Review Comment:
+1, the code is getting harder to follow. I have reviewed this part code
several times in the past two weeks but still need to refresh my memory every
time I see it :)
I think we can create a tracking issue and have AI check if there is any
opportunity to refactor it
##########
crates/iceberg/src/arrow/record_batch_transformer.rs:
##########
Review Comment:
Since we added some good behavior changes/fixes to this function, can we
update the comment here to say that we now explicitly handle reordered schema
and mark them as different?
Also I think it would nice to have a test for this function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
