nssalian commented on PR #1478: URL: https://github.com/apache/iceberg-go/pull/1478#issuecomment-5008774128
Both the review items are addressed along with a few additional changes: - Incomplete row-group stats: a typed leaf with non-null values but no usable min/max is now invalidated and its bound dropped, only a provably all-null row group is skipped. - Ancestor residuals: each leaf carries its full ancestor residual value chain and drops its bound if any ancestor/self residual holds non-null data. - I added new regression tests for both - I also fixed a mislabeled comment in DataFileFromMetadata and added the missing bound-correctness test on that recompute path. - Rebased/merged onto latest main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
