kevinjqliu commented on code in PR #17211:
URL: https://github.com/apache/iceberg/pull/17211#discussion_r3607389076
##########
docs/docs/view-configuration.md:
##########
@@ -24,11 +24,12 @@ title: "Configuration"
Iceberg views support properties to configure view behavior. Below is an
overview of currently available view properties.
-| Property | Default | Description
|
-|----------------------------------|---------------------------|------------------------------------------------------------------------------------|
-| write.metadata.compression-codec | gzip | Metadata
compression codec: `none` or `gzip` |
-| version.history.num-entries | 10 | Controls the
number of `versions` to retain |
-| replace.drop-dialect.allowed | false | Controls
whether a SQL dialect is allowed to be dropped during a replace operation |
+| Property | Default | Description
|
+|----------------------------------|-----------------------------|------------------------------------------------------------------------------------|
+| write.metadata.compression-codec | gzip | Metadata
compression codec: `none` or `gzip` |
+| write.metadata.path | table location + /metadata | Base
location for view metadata files |
Review Comment:
i think this should be `view location` instead of `table location`, and it
would be useful to document the distinction discussed on dev@: when this
property is set, it takes precedence over the view location and metadata files
are written directly under the configured path without automatically appending
/metadata.
```suggestion
| write.metadata.path | view location + /metadata | Base
location for view metadata files. When set, metadata files are written directly
under this path without appending `/metadata`.
|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
