hectar-glitches commented on code in PR #1493: URL: https://github.com/apache/iceberg-go/pull/1493#discussion_r3609646226
########## encryption/kms_registry.go: ########## @@ -0,0 +1,120 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package encryption + +import ( + "errors" + "fmt" + "maps" + "slices" + "sync" +) + +// Catalog/table property keys used to select and configure a KeyManagementClient. +const ( + // KMSTypeKey selects a built-in KeyManagementClient implementation + // registered via [RegisterKMS] (e.g. "memory"). + KMSTypeKey = "encryption.kms-type" + + // KMSImplKey selects a custom KeyManagementClient implementation by a + // name registered via [RegisterKMS]. It is an alternative to + // [KMSTypeKey] for vendors that ship their own KMS integration under a + // distinct name; the two properties share the same registry and + // resolution mechanism. + KMSImplKey = "encryption.kms-impl" Review Comment: dropped kms-imply entirely leaving just KMSTypeKey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
