C-Loftus commented on code in PR #1426:
URL: https://github.com/apache/iceberg-go/pull/1426#discussion_r3610927769
##########
table/arrow_utils.go:
##########
@@ -528,6 +528,10 @@ func ensureSmallArrowTypes(dt arrow.DataType)
(arrow.DataType, error) {
}
type convertToArrow struct {
+ // the ctx stores table property metadata,
+ // for instance, projjson definitions that can be
+ // used when writing
+ ctx context.Context
Review Comment:
> @zeroshade — you rejected widening the visitor interface on
https://github.com/apache/iceberg-go/issues/1230; does the
ctx-carries-required-props shape sit right with you, or would you rather see
properties passed explicitly? This decision drives most of the rest of the PR,
so I'd like to settle it first.
@zeroshade would you be able to give your thoughts on this comment before I
address further feedback / wire up the rest of the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
