ajreid21 commented on PR #17195: URL: https://github.com/apache/iceberg/pull/17195#issuecomment-5023620363
@singhpk234 Yeah, the flink state properties are in the snapshot summary already. I think explicitly setting the engine-name property makes the downstream consumer logic simpler and there is less worry that this property name ([referenced in the spec](https://github.com/apache/iceberg/blob/1ec15051dc09ef6a0d61fa332eb8f2503f3170f8/format/spec.md?plain=1#L2112)) may change, etc. with potentially new engine version/implementations (plus you can't get engine version from the flink state properties - although I agree version is less important). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
