rambleraptor commented on code in PR #3666:
URL: https://github.com/apache/iceberg-python/pull/3666#discussion_r3618080069
##########
pyiceberg/table/__init__.py:
##########
@@ -117,6 +119,9 @@
ALWAYS_TRUE = AlwaysTrue()
DOWNCAST_NS_TIMESTAMP_TO_US_ON_WRITE = "downcast-ns-timestamp-to-us-on-write"
+# Retain a small working set for repeated relevant partition values without
adding
+# unbounded key storage when scans contain a distinct value for every data
file.
+_RESIDUAL_CACHE_MAX_SIZE = 128
Review Comment:
Can we have this as a property with this as the default? That would help
with some of the monkeypatching below
##########
pyiceberg/expressions/visitors.py:
##########
@@ -1785,7 +1785,7 @@ def _can_contain_nans(self, field_id: int) -> bool:
return (nan_count := self.nan_counts.get(field_id)) is not None and
nan_count > 0
-class ResidualVisitor(BoundBooleanExpressionVisitor[BooleanExpression], ABC):
Review Comment:
We're making this class private. That may be a breaking change. I'll let a
maintainer decide if we can do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
