dhruvarya-db commented on code in PR #2859:
URL: https://github.com/apache/iceberg-rust/pull/2859#discussion_r3618445925
##########
crates/iceberg/src/arrow/delete_filter.rs:
##########
@@ -296,6 +301,38 @@ pub(crate) mod tests {
const FIELD_ID_POSITIONAL_DELETE_FILE_PATH: u64 = 2147483546;
const FIELD_ID_POSITIONAL_DELETE_POS: u64 = 2147483545;
+ // Regression test for the positional-delete lost-wakeup hang.
Review Comment:
`load_file_for_task()` is hard to test deterministically without introducing
a test-only seam in its logic. I have created a separate repro-only PR with the
test-only seam if that helps build some confidence:
https://github.com/dhruvarya-db/iceberg-rust/pull/16/changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
