hkwi commented on PR #13225: URL: https://github.com/apache/iceberg/pull/13225#issuecomment-5031386837
Thanks for the discussion around the protected method signature change. I revisited this against the release history and prepared a reference patch in [hkwi/iceberg#2](https://github.com/hkwi/iceberg/pull/2). The release sequence appears to be: - Apache Iceberg 1.10.2 did not contain the protected RESTSessionCatalog.newTableOps extension hooks. - [#14465](https://github.com/apache/iceberg/pull/14465) added the custom REST table/view operations hooks and was merged on 2025-12-02. - Apache Iceberg 1.11.0 was released on 2026-05-14 with the original newTableOps signatures. - #13225 adds a KeyManagementClient parameter to those existing protected methods. Therefore, the “the API has not been released yet” rationale was understandable when discussed in January, but it no longer applies to a future release: the existing protected extension point is now part of the 1.11.0 API surface. Adding the parameter would break source compatibility for implementations overriding the 1.11.0 signatures. [hkwi/iceberg#2](https://github.com/hkwi/iceberg/pull/2) is a fork-only draft reference patch based directly on the imported #13225 branch. It keeps both existing RESTSessionCatalog.newTableOps signatures unchanged, while the default implementations pass the catalog-private KMS client to RESTTableOperations. The encryption implementation from #13225 is otherwise left unchanged. This is intended as a concrete reference for preserving the released protected API, rather than as a separate upstream PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
