gaborkaszab commented on PR #17219: URL: https://github.com/apache/iceberg/pull/17219#issuecomment-5031538042
Thanks you for the explanation, @HaoXuAI ! I personally feel, that we can't really find usage for such a functionality within the Iceberg library itself ATM. As you described you use this approach in one of your systems to get some snapshot metrics without forcing to load the full snapshot list into `TableMetadata`. However, that usage is not within the library but within some external metrics gathering system. If we can't find any meaningful usage that is not external, I'm leaning towards not introducing further complexity and additional code to maintain TBH. Let's wait if anyone else has a different opinion here. Additional remark: you mentioned measurement with 200k snapshots. I think that's an extremely high number. In my experience, you probably want to expire snapshots when you have a couple of thousands not tens or hundreds of thousands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
