rdblue commented on issue #1680: URL: https://github.com/apache/iceberg/issues/1680#issuecomment-752223855
I started working on this and realized that it is simpler to account for the bad values produced by version 0.10.0 and older. Testing showed that the date transform didn't have the bug, so documenting the behavior would be more complicated in the spec. In addition, adding new transforms to the spec would be a much larger addition than adding example test cases and noting old versions that were affected because it would require twice as many supported date/time transforms. Instead, I chose to adjust when projecting data predicates to partition predicates. The advantage is that the update to the spec only needs to be a few test values and a note about the behavior of old versions. Getting this in by v2 also means that the adjustment isn't needed for tables that are created as v2 tables because v1 writers with the problem cannot read or write v2 tables. #1981 has more extensive tests for date/time transforms and adjusts predicates while projecting to account for the transform bug. Once that is in, I'll update the spec with test values, a description of the problem, and affected versions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
