huaxingao commented on code in PR #14984: URL: https://github.com/apache/iceberg/pull/14984#discussion_r3623934652
########## spark/v4.2/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/IcebergAlterV2ViewSetPropertiesExec.scala: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.spark.sql.execution.datasources.v2 + +import org.apache.iceberg.catalog.{ViewCatalog => IcebergViewCatalog} +import org.apache.iceberg.spark.Spark3Util +import org.apache.iceberg.spark.source.HasIcebergCatalog +import org.apache.iceberg.spark.source.SparkView +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.analysis.ViewUtil +import org.apache.spark.sql.catalyst.expressions.Attribute +import org.apache.spark.sql.connector.catalog.Identifier +import org.apache.spark.sql.connector.catalog.ViewCatalog +import scala.jdk.CollectionConverters._ + +/** + * Executes ALTER VIEW SET TBLPROPERTIES for Spark V2 views. + * + * Uses a custom command instead of Spark's built-in implementation so Iceberg catalogs commit + * property-only metadata updates and reject changes to reserved view properties. + */ +case class IcebergAlterV2ViewSetPropertiesExec( + catalog: ViewCatalog, + ident: Identifier, + properties: Map[String, String]) + extends LeafV2CommandExec { + + override lazy val output: Seq[Attribute] = Nil + + override protected def run(): Seq[InternalRow] = { + properties.keys.foreach(verifyNonReservedPropertyIsSet) + + catalog match { + case catalogWithIceberg: HasIcebergCatalog + if catalogWithIceberg.icebergCatalog().isInstanceOf[IcebergViewCatalog] => + val icebergViewCatalog = + catalogWithIceberg.icebergCatalog().asInstanceOf[IcebergViewCatalog] + val view = + icebergViewCatalog.loadView(Spark3Util.identifierToTableIdentifier(ident)) + val update = view.updateProperties() + properties.foreach { case (key, value) => update.set(key, value) } + update.commit() + + case _ => Review Comment: Has this branch ever been reached? Since the exec is only produced for a `ResolvedV2View`, whose catalog already passed the `HasIcebergCatalog` + `ViewCatalog` gate in `ViewUtil.loadView`, I can't see how a resolved Iceberg view would land here. If it's unreachable, can we drop it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
