stevenzwu commented on code in PR #17322:
URL: https://github.com/apache/iceberg/pull/17322#discussion_r3624973247
##########
core/src/main/java/org/apache/iceberg/FieldStatsStruct.java:
##########
@@ -54,8 +54,8 @@ class FieldStatsStruct<T> implements FieldStats<T>,
StructLike, Serializable {
T upperBound,
boolean tightBounds,
long valueCount,
- long nullValueCount,
- long nanValueCount,
+ Long nullValueCount,
Review Comment:
Boxed `Long` (not primitive `long`) for the two counts so a caller can pass
`null` for a metric the field's type does not track;
`hasNullCount()`/`hasNaNCount()` then report presence as `!= null`.
`valueCount` stays primitive since every column has one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
