thswlsqls opened a new pull request, #17328: URL: https://github.com/apache/iceberg/pull/17328
Closes #17326 ## Summary - `TestDebeziumTransform.testDmsTransformNull()` instantiated `DmsTransform`, not `DebeziumTransform`, and `TestDmsTransform` (line 50-57) already holds that test verbatim — so the copy verified nothing new. - The tombstone pass-through branch in `DebeziumTransform.apply()` (line 66-67) was therefore left uncovered by every test in the module. - The other four SMT tests each cover their own null path (`TestDmsTransform` 51, `TestCopyValue` 35, `TestJsonToMapTransform` 54, `TestKafkaMetadataTransform` 48); `TestDebeziumTransform` was the only one that did not. - This PR instantiates `DebeziumTransform` and asserts the record is returned as-is via `isSameAs`, matching `TestJsonToMapTransform` 68 and `TestKafkaMetadataTransform` 55. `TestDmsTransform` is untouched. - Origin: 7d9e96f9f6 (#11936) added both SMTs in one commit; the null test was copied across without switching the class under test. ## Testing done - `./gradlew :iceberg-kafka-connect:iceberg-kafka-connect-transforms:check` — 69 tests, 0 failures. - `testDebeziumTransformNull` passes both before and after this change: it fills a coverage gap, not a red-to-green bug fix. - Not vacuous — removing line 66-67 from `apply()` makes it fail with `DataException: Only Map objects supported in absence of schema`. That edit was reverted; no production code changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
