vaquarkhan opened a new pull request, #17331: URL: https://github.com/apache/iceberg/pull/17331
## What Update `jmh.gradle` so the benchmark suite runs on a clean JDK 17 checkout: - add the `--add-opens` set Spark 4.x needs (`sun.util.calendar`, nio, security, concurrent) - make heap configurable: `-PjmhHeap` (default preserved at `32g`) - make `failOnError` configurable: `-PjmhFailOnError` (default preserved at `true`) ## Why On JDK 17 the read-path benchmarks throw `IllegalAccessException` (`sun.util.calendar`) at warm-up, and the full-scale `PlanningBenchmark` WithStats OOMs at 32g. Contributors currently cannot reproduce benchmarks without local edits. See #17330. ## Testing - JDK 17: `./gradlew help`, `./gradlew spotlessApply`, `./gradlew :iceberg-core:jmhClasses` succeed with the updated harness - Defaults unchanged for existing users: heap `32g`, `failOnError` true unless `-P` flags are passed - JDK 21: `--add-opens` remain inert via `-XX:+IgnoreUnrecognizedVMOptions` Closes #17330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
