LuciferYang commented on code in PR #838:
URL: https://github.com/apache/iceberg-cpp/pull/838#discussion_r3628144688
##########
.github/workflows/cpp-linter.yml:
##########
@@ -91,24 +91,36 @@ jobs:
with:
path: ${{ github.workspace }}/.sccache
key: sccache-cpp-linter-ubuntu-${{ github.run_id }}
- - uses:
cpp-linter/cpp-linter-action@0f6d1b8d7e38b584cbee606eb23d850c217d54f8 # v2.15.1
+ - uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 #
v6.3.0
+ if: github.event_name == 'pull_request'
+ - name: Install cpp-linter and clang tools
+ if: github.event_name == 'pull_request'
+ run: pip install "cpp-linter==1.13.0" "clang-format==22.1.8"
"clang-tidy==22.1.8"
Review Comment:
Good catch, done. Pinned setup-python to 3.13 and switched to `python -m pip
install` so it uses the interpreter the action set up. I kept the run step as
`cpp-linter` (its console entry point) since the package has no `__main__`, so
it can't be called with `python -m`; it's installed into the same interpreter,
so they stay in sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
