Copilot commented on code in PR #839:
URL: https://github.com/apache/iceberg-cpp/pull/839#discussion_r3629212450
##########
.github/workflows/test.yml:
##########
@@ -25,6 +25,12 @@ on:
- '**'
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
+ paths-ignore:
+ - '.devcontainer/**'
+ - '*.md'
+ - '**/*.md'
+ - 'dev/**'
+ - 'mkdocs/**'
Review Comment:
`'*.md'` is redundant if `'**/*.md'` already matches Markdown files at the
repo root (as it typically does in GitHub Actions globbing). Dropping the
duplicate pattern would reduce noise and make the intent clearer. The same
redundancy appears in other updated workflows as well.
##########
.github/workflows/aws_test.yml:
##########
@@ -25,6 +25,12 @@ on:
- '**'
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
+ paths-ignore:
+ - '.devcontainer/**'
+ - '*.md'
+ - '**/*.md'
+ - 'dev/**'
+ - 'mkdocs/**'
Review Comment:
With `paths-ignore`, this workflow will not run at all for PRs that only
touch ignored paths. If this workflow is configured as a required status check
in branch protection, skipped runs can prevent merging because no check result
is produced. If it’s required, consider keeping the workflow triggered for all
PRs and conditionally skipping the heavy jobs based on a paths filter step (so
the check still reports success), or adjust branch protection to not require it
for docs/dev-only changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
