kamcheungting-db commented on PR #725: URL: https://github.com/apache/iceberg-cpp/pull/725#issuecomment-5048753357
> Thanks for reworking this. The structure looks much better now, and this looks good to me.\n\nI still slightly prefer preprocessor gating for the active-level macros, but I don't think that needs to block this PR. Acked. I would move to preprocessor gating in next PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
