hsiang-c commented on code in PR #2865:
URL: https://github.com/apache/iceberg-rust/pull/2865#discussion_r3632389485
##########
crates/iceberg/src/metadata_columns.rs:
##########
@@ -478,15 +484,26 @@ pub fn is_metadata_field(field_id: i32) -> bool {
)
}
-/// Checks if a column name is a metadata column.
+/// Checks if a column name is a metadata column of a data table.
Review Comment:
Confirm that Iceberg Java return false for `row`, `pos` and `file_path`:
```java
MetadataColumns.isMetadataColumn(MetadataColumns.DELETE_FILE_ROW_FIELD_ID)
MetadataColumns.isMetadataColumn(MetadataColumns.DELETE_FILE_ROW_FIELD_NAME)
MetadataColumns.isMetadataColumn(MetadataColumns.DELETE_FILE_POS.fieldId())
MetadataColumns.isMetadataColumn(MetadataColumns.DELETE_FILE_POS.name())
MetadataColumns.isMetadataColumn(MetadataColumns.DELETE_FILE_PATH.fieldId())
MetadataColumns.isMetadataColumn(MetadataColumns.DELETE_FILE_PATH.name())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
