dramaticlly commented on code in PR #16849:
URL: https://github.com/apache/iceberg/pull/16849#discussion_r3632966798
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -162,6 +163,14 @@ private TrackedFileStruct(TrackedFileStruct toCopy,
boolean withStats, Set<Integ
: null;
}
+ /** Sets the first row id on this {@link TrackedFileStruct} */
+ public void setFirstRowId(int firstRowId) {
+ Preconditions.checkState(
+ contentType == FileContent.DATA || contentType ==
FileContent.DATA_MANIFEST,
+ "Cannot set first row id on an equality delete or delete manifest
entry");
Review Comment:
nit: instead of saying what's not allowed. Would stating only allow the
supported content type be more explicit?
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -162,6 +163,14 @@ private TrackedFileStruct(TrackedFileStruct toCopy,
boolean withStats, Set<Integ
: null;
}
+ /** Sets the first row id on this {@link TrackedFileStruct} */
+ public void setFirstRowId(int firstRowId) {
Review Comment:
curious, should firstRowId be long type instead, like in TrackingStruct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
