nssalian commented on code in PR #16913:
URL: https://github.com/apache/iceberg/pull/16913#discussion_r3633665994
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnVectorWithFilter.java:
##########
@@ -134,18 +139,30 @@ public byte[] getBinary(int rowId) {
@Override
public ColumnVector getChild(int ordinal) {
+ if (dataType() instanceof ArrayType || dataType() instanceof MapType) {
Review Comment:
this array/map branch is doing the real work here but it's just a bare
instanceof with no explanation. Worth adding a one-liner on why these children
come back unfiltered - getArray/getMap already remapped the top-level row, so
element children are absolute offsets and shouldn't be remapped again. Just so
a future reader doesn't reintroduce a double-remap. Would add it across
3.5/4.0/4.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
