zenfenan commented on code in PR #3658:
URL: https://github.com/apache/iceberg-python/pull/3658#discussion_r3633775601
##########
pyiceberg/table/__init__.py:
##########
@@ -2151,11 +2151,7 @@ def _open_manifest(
Returns:
A list of ManifestEntry that matches the provided filters.
"""
- return [
Review Comment:
Thanks for the review! I agree on both points.
My initial approach was a separate method to avoid any risk of side effects
to existing callers but the optional `entry_filter` defaulting to `None`
achieves the same safety without duplicating the Avro reader setup. I have
updated the PR to include this but kept the other call site migration for a
follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
