rdblue commented on code in PR #17322:
URL: https://github.com/apache/iceberg/pull/17322#discussion_r3634632237
##########
core/src/main/java/org/apache/iceberg/FieldStatsStruct.java:
##########
@@ -54,8 +54,8 @@ class FieldStatsStruct<T> implements FieldStats<T>,
StructLike, Serializable {
T upperBound,
boolean tightBounds,
long valueCount,
- long nullValueCount,
- long nanValueCount,
+ Long nullValueCount,
Review Comment:
I disagree with this change. The cases where null count can be null do not
go through this path. This constructor should require non-null counts for both
nan value count and null value count (though not `avgValueSize`) because both
should be known when generating stats. I don't know of a case where we write a
file and have stats, but don't know the NaN count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
