rambleraptor commented on code in PR #2881:
URL: https://github.com/apache/iceberg-python/pull/2881#discussion_r3634894962
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1605,13 +1596,25 @@ def _get_column_projection_values(
for field_id in project_schema_diff:
for partition_field in partition_spec.fields_by_source_id(field_id):
if isinstance(partition_field.transform, IdentityTransform):
- partition_value =
accessors[partition_field.field_id].get(file.partition)
- if partition_value is not None:
+ if partition_value :=
accessors[partition_field.field_id].get(file.partition):
projected_missing_fields[field_id] = partition_value
return projected_missing_fields
+@contextmanager
+def _handle_unsupported_pyarrow_uuid_filter() -> Iterator[None]:
+ try:
+ yield
+ except pyarrow.lib.ArrowNotImplementedError as e:
+ if "arrow.uuid" in str(e):
Review Comment:
This is a drive-by review (I haven't done a deep-dive)
Is there a way to do this without looking for strings in error messages?
This seems brittle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
