fallintoplace opened a new pull request, #1515: URL: https://github.com/apache/iceberg-go/pull/1515
## Summary - compute default sort direction and null order in local variables - preserve the existing JSON output without changing the `SortField` receiver ## Why `SortField.MarshalJSON` wrote default values back into the field being serialized. Marshaling should be read-only; mutating caller state is surprising and can race when a field is serialized concurrently. ## Testing - `go test ./...` - `go test -race ./table` - `golangci-lint run --timeout=10m` - `go vet ./...` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
