Copilot commented on code in PR #840:
URL: https://github.com/apache/iceberg-cpp/pull/840#discussion_r3635217840
##########
src/iceberg/transform.h:
##########
@@ -275,10 +275,11 @@ class ICEBERG_EXPORT TransformFunction {
return lhs.Equals(rhs);
Review Comment:
`operator==` delegates to `lhs.Equals(rhs)`. Now that `Equals` is
virtual/overridable (and overridden by parameterized transforms), this can
violate symmetry when comparing through base references (e.g., if a future
subclass adds state): `a == b` may differ from `b == a`. Make `operator==`
enforce symmetry by checking both directions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
