mxm commented on code in PR #17276:
URL: https://github.com/apache/iceberg/pull/17276#discussion_r3637185695
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/HashKeyGenerator.java:
##########
Review Comment:
Should we also test this branch?
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestHashKeyGenerator.java:
##########
@@ -164,6 +164,48 @@ void testEqualityKeys() throws Exception {
assertThat(getSubTaskId(writeKey3, writeParallelism,
maxWriteParallelism)).isEqualTo(0);
}
+ @Test
+ void rangeModeWithEqualityFields() throws Exception {
Review Comment:
Since `RANGE` is not properly supported, how about
`testRangeModeFallsBackToDistributionModeNone`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
