xanderbailey opened a new pull request, #2882: URL: https://github.com/apache/iceberg-rust/pull/2882
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Add a `read_all` method to the `FileRead` trait for reading an entire file's content without the caller having to know its length. Each implementation knows its own size, and for encrypted readers (`AesGcmFileRead`) it returns the decrypted plaintext. This will allow a future `ManifestReader` to store just a `dyn FileRead` with a `new(InputFile)` and `new_from_encrypted(EncryptedInputFile)` constructor. For the OpenDal reader this also skips a HEAD request made to get the file length so it's slightly cheaper. Working towards https://github.com/apache/iceberg-rust/issues/2881 ## What changes are included in this PR? Add a `read_all` method to the `FileRead` trait <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
