u70b3 commented on code in PR #841:
URL: https://github.com/apache/iceberg-cpp/pull/841#discussion_r3643063543
##########
src/iceberg/catalog/rest/json_serde.cc:
##########
@@ -323,10 +324,11 @@ Result<std::vector<std::shared_ptr<FileScanTask>>>
FileScanTasksFromJson(
GetJsonValue<nlohmann::json>(task_json,
kDataFile));
ICEBERG_ASSIGN_OR_RAISE(
auto data_file, DataFileFromJson(data_file_json, partition_spec_by_id,
schema));
- // FIXME: REST scan-task DataFile JSON currently carries first-row-id,
- // but not the manifest-entry data sequence number. Until the REST API
exposes
- // it, REST-planned tasks cannot inherit _last_updated_sequence_number.
- // See https://github.com/apache/iceberg-cpp/issues/834.
+ if (task_json.contains(kDataSequenceNumber) &&
Review Comment:
Understood — I'll keep this as a draft blocked on the upstream REST spec
adopting the field. I don't plan to file the spec proposal right now; happy to
revisit once the protocol supports it. Feel free to close this PR if you'd
rather not keep it open in the meantime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
