Guosmilesmile opened a new pull request, #17351:
URL: https://github.com/apache/iceberg/pull/17351

   The documented value `0.02` is inconsistent with the actual weighting logic 
in MapAssignment, where the value is divided by 100 
(`closeFileCostWeightPercentage / 100`). `rangeDistributionSortKeyBaseWeight` 
will be directly assigned to `closeFileCostWeightPercentage`.
   
   
https://github.com/apache/iceberg/blob/8de28da314ec2f13251dac8b7dc0c7de1f899d2e/flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/MapAssignment.java#L129-133
   
   
   
   To represent 2%, users should set `2.0`, not `0.02`. This fixes the 
incorrect weight value in the documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to