xanderbailey commented on code in PR #2887:
URL: https://github.com/apache/iceberg-rust/pull/2887#discussion_r3645388640
##########
crates/iceberg/src/spec/table_properties.rs:
##########
@@ -317,6 +353,36 @@ impl TableProperties {
/// Default matches `parquet::file::properties::DEFAULT_CDC_NORM_LEVEL`.
pub const PROPERTY_PARQUET_CDC_NORM_LEVEL_DEFAULT: i32 = 0;
+ /// Compression codec for Parquet data files (e.g. `zstd`, `gzip`,
`snappy`,
+ /// `lz4`, `brotli`, `uncompressed`). The codec name is validated when the
+ /// writer is built, not when properties are parsed.
+ pub const PROPERTY_PARQUET_COMPRESSION_CODEC: &str =
"write.parquet.compression-codec";
+ /// Default Parquet compression codec (matches Iceberg's default since
1.4.0).
+ pub const PROPERTY_PARQUET_COMPRESSION_CODEC_DEFAULT: &str = "zstd";
Review Comment:
Have called this out in the PR description but current default is actually
uncompressed from what I can see.
This opens up a question generally as to if we should copy the Java defaults
for these settings which might be more intuitive for user or keep the defaults
as the arrow-rs defaults... I don't have a strong opinion here so interested to
hear people's thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
