badalprasadsingh commented on code in PR #1423:
URL: https://github.com/apache/iceberg-go/pull/1423#discussion_r3647255731
##########
io/gocloud/s3.go:
##########
@@ -156,6 +158,70 @@ func applyS3TransportTuning(t *http.Transport) {
// path-style addressing. It defaults to virtual-hosted style for
// standard AWS S3 and path-style for custom endpoints (e.g. MinIO).
// The s3.force-virtual-addressing property can override either default.
+func applyS3ClientOptions(endpoint string, props map[string]string)
func(*s3.Options) {
+ return func(o *s3.Options) {
+ if endpoint != "" {
Review Comment:
Done.
Went with the dedicated-property route you suggested: added `s3.compat-mode`
(default off), so `s3.endpoint`/`AWS_S3_ENDPOINT` behavior is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
