ismailsimsek commented on a change in pull request #1870: URL: https://github.com/apache/iceberg/pull/1870#discussion_r550470807
########## File path: core/src/main/java/org/apache/iceberg/jdbc/JdbcClientPool.java ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.jdbc; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.SQLException; +import java.sql.SQLNonTransientConnectionException; +import java.sql.SQLTimeoutException; +import java.sql.SQLTransientConnectionException; +import java.sql.SQLWarning; +import java.util.Properties; +import org.apache.iceberg.ClientPool; +import org.apache.iceberg.exceptions.UncheckedSQLException; + +public class JdbcClientPool extends ClientPool<Connection, SQLException> { + + private final String dbUrl; + private final Properties dbProperties; + + JdbcClientPool(String dbUrl, Properties props) { Review comment: i see updated it, @rdblue what do you think about passing additional jdbc parameters with following prefix? is it okay or there shuld be no prefix? `public static final String JDBC_PARAM_PREFIX = "connection.parameter.";` current setup will be like ``` spark.sql.catalog.catalog_name.uri=jdbc:postgresql://localhost:5432/mydatabase spark.sql.catalog.catalog_name.connection.parameter.user=myuser spark.sql.catalog.catalog_name.connection.parameter.password=mypass spark.sql.catalog.catalog_name.connection.parameter.ssl=true spark.sql.catalog.catalog_name.connection.parameter.param1=val1 spark.sql.catalog.catalog_name.connection.parameter.param2=val2 ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
